Filter vs pi-simple-controller

[jaxsin]

I been staring at this piece of code for a while now and I am positive it should work as a filter, but why not?

Code: Select all

    <pi-simple-controller>
        <name>Roll</name>
        <debug>false</debug>
        <enable>
            <condition>
                <equals>
                    <property>instrumentation/fgc-65/internal/lateral</property>
                    <value>ROLL</value>
                </equals>
            </condition>
        </enable>
        <input>
            <property>/orientation/roll-deg</property>
        </input>
        <reference>
            <property>instrumentation/fgc-65/settings/roll</property>
        </reference>
        <output>
            <property>instrumentation/fgc-65/internal/fd/roll</property>
        </output>
        <config>
            <Kp>1.0</Kp>
            <Ki>0.0</Ki>
            <min>
                <property>instrumentation/fgc-65/app-65a/BANK</property>
                <scale>-30.0</scale>
            </min>
            <max>
                <property>instrumentation/fgc-65/app-65a/BANK</property>
                <scale>30.0</scale>
            </max>
        </config>
    </pi-simple-controller>


This is what I have tried

Code: Select all

    <filter>
        <name>Roll</name>
        <debug>false</debug>
        <enable>
            <condition>
                <equals>
                    <property>instrumentation/fgc-65/internal/lateral</property>
                    <value>ROLL</value>
                </equals>
            </condition>
        </enable>
        <type>gain</type>
        <input>
            <property>/orientation/roll-deg</property>
        </input>
        <reference>
            <property>instrumentation/fgc-65/settings/roll</property>
        </reference>
        <gain>1.0</gain>
        <output>
            <property>instrumentation/fgc-65/internal/fd/roll</property>
        </output>
        <min>
                <property>instrumentation/fgc-65/app-65a/BANK</property>
                <scale>-30.0</scale>
        </min>
        <max>
                <property>instrumentation/fgc-65/app-65a/BANK</property>
                <scale>30.0</scale>
        </max>
    </filter>

[curt]

I'm pretty sure conditions are not supported in the autopilot configure (unless I'm mistaken.) I'm also not sure about relative property paths. You would want the block to look more like:

<enable>
<property>/instrumentation/fgc-65/internal/lateral</property>
<value>ROLL</value>
</enable>

The component should activate when the enable property is equal to the enable value.

Curt.

[jaxsin]

Autopilot reference

If I am reading this correctly it seems to say otherwise? In fact I think it is telling me that the way you reference was at sometime supposed to deprecated?

[Octal450]

I know this thread is dead, but I have the solution. Invert the sign on the <gain> in the filter. That fixes it. For some reason, the pi-simple-controller has the signs inverted from all filters (derivative, gain, integrator, etc)

And yes, conditions work fine inside <enable>

Kind Regards,
Josh