Board index FlightGear Development Effects and shaders

ALS landing lights

An exciting "new" option in FlightGear, that includes reflections, lightmaps, the particle system etc.. A lot is yet to be discovered/implemented!

Re: ALS landing lights

Postby Thorsten » Tue Feb 17, 2015 6:17 am

Sorry, I can't reproduce that.

Neither can I come up with a scenario in which this would happen - inside the code are simple if-statements checking the properties. Even if the properties would not be transmitted by the effect framework, they'd arrive as logical zero and lights would never ever switch on.

You're also the first one to report this despite the lights being on GIT for a few months now, so it smells like something specific for your setup. Short of just testing a wide variety of conditions and seeing if anything makes a difference, I don't even know what to ask for...
Thorsten
 
Posts: 11649
Joined: Mon Nov 02, 2009 8:33 am

Re: ALS landing lights

Postby wlbragg » Tue Feb 17, 2015 6:41 am

What aircraft were you using?
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 5607
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: ALS landing lights

Postby Necolatis » Tue Feb 17, 2015 7:01 am

I was using the JA37 version 3.002

I installed it some months ago, haven't really looked at it many times since, due to not normally flying with that high shader setting.
Discovered it by accident this morning, switched to external view, the logic then switch the landing light off, but I still see it.

Image
"Airplane travel is nature's way of making you look like your passport photo."
— Al Gore
User avatar
Necolatis
 
Posts: 2108
Joined: Mon Oct 29, 2012 12:40 am
Location: EKOD
Callsign: Leto
IRC name: Neco
Version: 2019.1.2
OS: Windows 10

Re: ALS landing lights

Postby Thorsten » Tue Feb 17, 2015 7:13 am

Not clear from the screenshot - what are the detailed quality settings, do you only see it on airport keep or on other landclasses, does it happen for other planes, is it specific for external view, can you trigger it somehow, make it go away?
Thorsten
 
Posts: 11649
Joined: Mon Nov 02, 2009 8:33 am

Re: ALS landing lights

Postby wlbragg » Tue Feb 17, 2015 7:41 am

Did you know there is a landing light switch on the right side of the aircraft cockpit?
Mine appears to be stuck in the off position. Even when switched on. Debug cannot override it.
My version appears to be 2.8+..
I have a feeling this is an aircraft specific problem.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 5607
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: ALS landing lights

Postby Necolatis » Tue Feb 17, 2015 7:55 am

Only on runway and taxiways. The snow in between the runways also is not lit up. Outside the airport is also does not work.
Airport EKCH, also tried KNUQ, same problem.
It happens also in internal view.
I cannot seem to do anything to the properties to make it go away, and changing the degrees does not seem to move it. Reseting the sim, also does not help.
It follows the camera, so maybe its the searchlight?
Turning alt landing light on, gives no result.
Setting quality down to 3 makes it go away, but it appears again, when I set it back up.
Rendering settings: als ON, quality 5, particles ON, precipitation ON, 3D clouds ON, point sprites ON, terrain: region specific, rest OFF

Now tried to start the sim up again (haven't done that since I saw the bug), and all 3 lights work as they should in the CH47 same for the JA37. Don't know what triggered the bug.
"Airplane travel is nature's way of making you look like your passport photo."
— Al Gore
User avatar
Necolatis
 
Posts: 2108
Joined: Mon Oct 29, 2012 12:40 am
Location: EKOD
Callsign: Leto
IRC name: Neco
Version: 2019.1.2
OS: Windows 10

Re: ALS landing lights

Postby Necolatis » Tue Feb 17, 2015 8:05 am

wlbragg wrote in Tue Feb 17, 2015 7:41 am:Did you know there is a landing light switch on the right side of the aircraft cockpit?
Mine appears to be stuck in the off position. Even when switched on. Debug cannot override it.
My version appears to be 2.8+..
I have a feeling this is an aircraft specific problem.


If you mean on the left sidepanel, then yes. When it is switched on it only sets the property to true, when a certain amount of voltage is supplied.
There is a switch on the main panel on the right upper side, that can seem stuck when on the runway, but that is for dropping the drop-tank. If that is not the switch you mean, I am very interested in that stuck switch. Maybe send a message to me regarding it, and I will take a look?
"Airplane travel is nature's way of making you look like your passport photo."
— Al Gore
User avatar
Necolatis
 
Posts: 2108
Joined: Mon Oct 29, 2012 12:40 am
Location: EKOD
Callsign: Leto
IRC name: Neco
Version: 2019.1.2
OS: Windows 10

Re: ALS landing lights

Postby wlbragg » Tue Feb 17, 2015 8:11 am

Yes, on the left side panel. I just downloaded version 3+ off the site and will install and report back tomorrow.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 5607
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: ALS landing lights

Postby Necolatis » Tue Feb 17, 2015 10:03 am

I now have the bug again. It appeared after using reset from the menu.
"Airplane travel is nature's way of making you look like your passport photo."
— Al Gore
User avatar
Necolatis
 
Posts: 2108
Joined: Mon Oct 29, 2012 12:40 am
Location: EKOD
Callsign: Leto
IRC name: Neco
Version: 2019.1.2
OS: Windows 10

Re: ALS landing lights

Postby Thorsten » Tue Feb 17, 2015 12:24 pm

Okay, I can reproduce that (I never use reset, because it causes so many issues).

It seems properties aren't passed correctly to the shaders after a reset, probably the uniform factory code isn't reset proof. I'm getting the same behaviour for the ground haze or the air pollution, which are just frozen to whatever value they were before a reset.

I'll make a report to the devel list.
Thorsten
 
Posts: 11649
Joined: Mon Nov 02, 2009 8:33 am

Re: ALS landing lights

Postby Necolatis » Thu Mar 12, 2015 4:08 pm

I also made a bugreport so it wont be forgotten: https://code.google.com/p/flightgear-bu ... il?id=1702
"Airplane travel is nature's way of making you look like your passport photo."
— Al Gore
User avatar
Necolatis
 
Posts: 2108
Joined: Mon Oct 29, 2012 12:40 am
Location: EKOD
Callsign: Leto
IRC name: Neco
Version: 2019.1.2
OS: Windows 10

Re: ALS landing lights

Postby dg-505 » Wed May 20, 2015 8:20 pm

Can I set the property
Code: Select all
sim/rendering/als-secondary-lights/landing-light1-offset-deg
in a configuration file, or do I have to set it via the Property browser?

EDIT: Figured it out: set the desired value under
Code: Select all
<sim>
    <rendering>
        <als-secondary-lights>
            <landing-light1-offset-deg type="float">-5</landing-light1-offset-deg>
        </als-secondary-lights>
    </rendering>
</sim
in the aircraft-set.xml
A mile of road will take you a mile, but a mile of runway will take you everywhere.

DHC-6 Twin Otter development
User avatar
dg-505
 
Posts: 656
Joined: Mon Jun 02, 2014 2:36 pm
Location: Bonn, Germany
Callsign: dg-505
Version: next
OS: Ubuntu 18.04.4 LTS

Re: ALS landing lights

Postby Thorsten » Thu Oct 22, 2015 9:10 am

Wayne Bragg has kindly extended the framework to include a vertical displacement of the light, and I've just committed this, so now landing lights should can be positioned reasonably for tail-draggers as well.

Change /sim/rendering/als-secondary-lights/landing-light3-offset-deg to a value of your choice if you need a vertical displacement of the cone.
Thorsten
 
Posts: 11649
Joined: Mon Nov 02, 2009 8:33 am

Re: ALS landing lights

Postby Necolatis » Fri Dec 11, 2015 10:12 am

I have just tested the landing light in win 3.7 nightly:

The vertical displacement feature is very nice!

I found a bug though:

- When I pan the view to the left, the cone moves to the right, when looking up, the cone moves down. So looking around the cockpit, actually it appears as some sort of flashlight that randomly illuminates parts of inner cockpit. For example, if I have set the cone to point down, I can just look down and it will move up so high it no longer hits the runway. I just confirmed this bug is in 3.4 also, I didn't use to have that problem, maybe its cause my default cockpit view is zoomed more in now, and the shader don't take that into account?

My cockpit view is here:
Code: Select all
<view n="0">
  <internal>true</internal>
  <config>
    <pitch-offset-deg type="double">-23</pitch-offset-deg>
    <x-offset-m type="double">0</x-offset-m>
    <y-offset-m type="double">0.71</y-offset-m>
    <z-offset-m type="double">-3.6</z-offset-m>
    <default-field-of-view-deg type="double">95</default-field-of-view-deg>
  </config>
</view>


PS. I only use the primary landing light and also do not use the flashlight.

I also have a feature request, if the above bug gets fixed: A parameter to specify the cone width as an angle. The cone is so big in size that it cannot come out the front canopy without illuminating parts of the canopy.
"Airplane travel is nature's way of making you look like your passport photo."
— Al Gore
User avatar
Necolatis
 
Posts: 2108
Joined: Mon Oct 29, 2012 12:40 am
Location: EKOD
Callsign: Leto
IRC name: Neco
Version: 2019.1.2
OS: Windows 10

Re: ALS landing lights

Postby Thorsten » Fri Dec 11, 2015 11:17 am

I need to see this myself - which plane do I pull to look at this?
Thorsten
 
Posts: 11649
Joined: Mon Nov 02, 2009 8:33 am

PreviousNext

Return to Effects and shaders

Who is online

Users browsing this forum: No registered users and 0 guests