Map: coord parsing

[Hooray]

@Tom:
https://gitorious.org/fg/canvas-hackers ... da#c106612

Just to be on the safe side, stuff like this feels conceptually wrong to me (it's a leftover from the original ND code):

Code: Select all

var lat = -50.00;
var lon = -80;
append(coords,"N"~lat);
append(coords,"E"~lon);


i.e. using N or E despite the number being negative, but does it matter ?

[TheTom]

Code: Select all

// "N-50" == "S50"
// "E80" == "W-80"
if( val[0] == 'N' || val[0] == 'S' )
  coord.type = GeoCoord::LATITUDE;
else if( val[0] == 'E' || val[0] == 'W' )
  coord.type = GeoCoord::LONGITUDE;
// ...
if( val[0] == 'S' || val[0] == 'W' )
  coord.value *= -1;


[Gijs]

Why do we need the N/S/E/W at all? Makes it a little more complicated than needed IMO. Mixing text and numbers...

[Hooray]

yeah, we had the same discussion, I was under the impression it would be used for computing things, but the initial part of the code uses it to parse lat/lon tuples, to tell the difference between latitude/longitude ranges.