Board index FlightGear Development Effects and shaders

The sky is falling

An exciting "new" option in FlightGear, that includes reflections, lightmaps, the particle system etc.. A lot is yet to be discovered/implemented!

The sky is falling

Postby daveculp » Fri Feb 21, 2014 6:08 pm

Unsnapped vertices in the sky dome? Version 3.1.0 from about a week ago.

Image
User avatar
daveculp
 
Posts: 503
Joined: Sun Feb 24, 2013 1:50 am
Location: Las Vegas, USA
Callsign: DCulp
Version: 2017.3.1
OS: Ubuntu 17.10

Re: The sky is falling

Postby f-ojac » Fri Feb 21, 2014 6:12 pm

Yep, this is known, I remember seeing it and a thread about it further down. Thorsten answered about it.
--
If you want to support my Terrasync server, hosted on a private server, you can donate here: http://ns334561.ip-5-196-65.eu/WS2.0/WS ... 2.0.1.html
f-ojac
 
Posts: 1276
Joined: Fri Mar 07, 2008 9:50 am
Version: GIT
OS: GNU/Linux

Re: The sky is falling

Postby daveculp » Fri Feb 21, 2014 6:14 pm

Excellent. Thanks f-ojac.
User avatar
daveculp
 
Posts: 503
Joined: Sun Feb 24, 2013 1:50 am
Location: Las Vegas, USA
Callsign: DCulp
Version: 2017.3.1
OS: Ubuntu 17.10

Re: The sky is falling

Postby DEEG » Fri Feb 21, 2014 7:32 pm

Hmm, I noticed that as well when I took my first flight in 3.0. Is there a fix?
Aircraft:
Diamond DA-20 "Katana"
Cessna 172p "Skyhawk"
Cessna 182 "Skylane"

Airports:
Queen City Muni (KXLL)
LV International (KABE)
User avatar
DEEG
 
Posts: 19
Joined: Thu Nov 14, 2013 1:10 pm
Location: Pennsylvania
Callsign: PA-WH04
Version: 3.0
OS: OSX 10.9 | Vista

Re: The sky is falling

Postby Thorsten » Fri Feb 21, 2014 7:36 pm

Unsnapped vertices in the sky dome?


My diagnosis says yes - someone who can affect the core probably needs to take a look at the skydome vertex structure at some point. I'm fairly certain this isn't a shader issue.
Thorsten
 
Posts: 11045
Joined: Mon Nov 02, 2009 8:33 am

Re: The sky is falling

Postby curt » Thu Feb 27, 2014 5:01 pm

I've looked for this a couple times and never could spot anything wrong ... it probably requires someone to go in and strip out portions of the code to try to figure out if this a vertex problem, normal problem, shader problem, or maybe it's some subtle combination of multiple things, etc.
curt
Administrator
 
Posts: 1174
Joined: Thu Jan 01, 1970 12:00 am
Location: Minneapolis, MN

Re: The sky is falling

Postby stuart » Thu Feb 27, 2014 10:00 pm

I took another look at this, and got lucky. I found a small indexing error which was causing one of the vertex positions to be wrong.

There's a fix now available in simgear/next.

-Stuart
G-MWLX
User avatar
stuart
Moderator
 
Posts: 1469
Joined: Wed Nov 29, 2006 9:56 am
Location: Edinburgh
Callsign: G-MWLX

Re: The sky is falling

Postby Hooray » Thu Feb 27, 2014 10:03 pm

wow-kudos, that's one of the longest-standing scenery "annoyances" I'm aware of!
Please don't send support requests by PM, instead post your questions on the forum so that all users can contribute and benefit
Thanks & all the best,
Hooray
Help write next month's newsletter !
pui2canvas | MapStructure | Canvas Development | Programming resources
Hooray
 
Posts: 11336
Joined: Tue Mar 25, 2008 8:40 am

Re: The sky is falling

Postby stuart » Thu Feb 27, 2014 10:13 pm

Yes - and one I've looked at before but not been able to find. I guess all bugs are shallow with sufficient eyes and time staring :).
G-MWLX
User avatar
stuart
Moderator
 
Posts: 1469
Joined: Wed Nov 29, 2006 9:56 am
Location: Edinburgh
Callsign: G-MWLX

Re: The sky is falling

Postby Hooray » Thu Feb 27, 2014 10:47 pm

if you keep making so many changes in a single month, we'll need a new newsletter category just for all the things you've been working on :lol:
Please don't send support requests by PM, instead post your questions on the forum so that all users can contribute and benefit
Thanks & all the best,
Hooray
Help write next month's newsletter !
pui2canvas | MapStructure | Canvas Development | Programming resources
Hooray
 
Posts: 11336
Joined: Tue Mar 25, 2008 8:40 am

Re: The sky is falling

Postby Thorsten » Fri Feb 28, 2014 6:46 am

Terrific, Stuart! Many thanks!
Thorsten
 
Posts: 11045
Joined: Mon Nov 02, 2009 8:33 am

Re: The sky is falling

Postby curt » Fri Feb 28, 2014 1:15 pm

Awesome Stuart, thanks!
curt
Administrator
 
Posts: 1174
Joined: Thu Jan 01, 1970 12:00 am
Location: Minneapolis, MN

Re: The sky is falling

Postby f-ojac » Fri Feb 28, 2014 4:22 pm

Great stuff, Stuart, thanks a lot!
--
If you want to support my Terrasync server, hosted on a private server, you can donate here: http://ns334561.ip-5-196-65.eu/WS2.0/WS ... 2.0.1.html
f-ojac
 
Posts: 1276
Joined: Fri Mar 07, 2008 9:50 am
Version: GIT
OS: GNU/Linux

Re: The sky is falling

Postby daveculp » Fri Feb 28, 2014 6:26 pm

Thanks, Stuart! When I saw those nested loops in the skydome algorithm I didn't think there was enough coffee at Starbucks to fuel an investigation. Kudos!
User avatar
daveculp
 
Posts: 503
Joined: Sun Feb 24, 2013 1:50 am
Location: Las Vegas, USA
Callsign: DCulp
Version: 2017.3.1
OS: Ubuntu 17.10

Re: The sky is falling

Postby wlbragg » Mon Mar 17, 2014 5:58 pm

Just compiled it, well done!
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
User avatar
wlbragg
 
Posts: 4903
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Debain/nVGT640


Return to Effects and shaders

Who is online

Users browsing this forum: No registered users and 0 guests