Board index FlightGear Development Spaceflight

Please test shuttle against "next"

Discussion about development and usage of spacecraft

Please test shuttle against "next"

Postby jsb » Thu Apr 30, 2020 10:25 am

Hi,

the canvas api.nas file was split into several files for better maintainability in future.
Please note that this is not a functional change so no change or errors are expected, but for QA I kindly ask to test the shuttle against the lastest version of fgdata and report if I missed something.
I did a test starting FG with the Shuttle on re-entry and I did not notice any errors but as I do not know the shuttle my testing is limited to pushing random buttons near the screens and see colorful things on them.

Thanks
Henning
jsb
 
Posts: 285
Joined: Sat Oct 25, 2014 9:17 pm
Location: Hamburg, Germany
Callsign: D-JSB
Version: next
OS: Win7/Linux

Re: Please test shuttle against "next"

Postby eatdirt » Thu Apr 30, 2020 3:52 pm

Hi there,
did a RTLS with last snapshot of 2020.2.0, everything works fine so far!

Cheers,
Chris.
eatdirt
 
Posts: 1012
Joined: Wed Aug 15, 2018 3:06 pm

Re: Please test shuttle against "next"

Postby GinGin » Thu Apr 30, 2020 7:49 pm

Perfect, Thanks for testing.
Need to install a branch for latest nightly
GinGin
 
Posts: 1580
Joined: Wed Jul 05, 2017 11:41 am
Location: Paris
Callsign: Gingin

Re: Please test shuttle against "next"

Postby eatdirt » Sat May 02, 2020 4:32 pm

Ok, got an error in one of my launches, I cannot tell if this is linked to canvas, but that concerns the displays, so may be that is relevant.

Code: Select all
184.78 [ALRT]:nasal      Nasal runtime error: No such member: pfd_button_pushed
184.78 [ALRT]:nasal        at /home/chris/.Aircraft/SpaceShuttle/Nasal/PFD/PFD_main.nas, line 572
184.78 [ALRT]:nasal        called from: /usr/share/games/flightgear/Nasal/globals.nas, line 119


Afterwards, avionics seem to work fine, but some functionalities of the displays were screwed. For instance, it was impossible to display BFS, changing modes from OPS 104 to 105 seems to work fine in the console:
Code: Select all
OPS 105
1115.07 [ALRT]:nasal      Switching to major_mode 105
1115.07 [ALRT]:nasal      Re-stringing...


but all displays were still showing OPS 104.

It is not systematics, most of my runs were running fine. And I started with nasal-gc-threaded=false.
eatdirt
 
Posts: 1012
Joined: Wed Aug 15, 2018 3:06 pm

Re: Please test shuttle against "next"

Postby wlbragg » Sat May 02, 2020 6:41 pm

This is another one best left for Thorsten, but.
Code: Select all
mnt/IDrive/FG/Aircraft/Development Aircraft/SpaceShuttle/Nasal/PFD/PFD_main.nas:
  567                          {
  568                              if (v.getValue())
  569:                                 me.pfd_button_pushed = v.getValue();
  570                              else
  571                              {
  572:                                 printf("%s: Button %d",me.designation, me.pfd_button_pushed);
  573:                                 me.PFD.notifyButton(me.pfd_button_pushed);
  574:                                 me.pfd_button_pushed = 0;
  575                              }
  576                          }
  ...
  596 
  597 
  598:         me.PFD.pfd_button_pushed = 0;

This is the only references to pfd_button_pushed and I can't tell if
me.PFD.pfd_button_pushed = 0;
is the correct space to initialize me.pfd_button_pushed.
Because, according to the line number of the error (572) it is when trying to use the variable me.pfd_button_pushed in the print statement
printf("%s: Button %d",me.designation, me.pfd_button_pushed);
where the error is.
You could simply comment out the printf statement and see if that gets rid of the error and all else should work, as it is appears to only be debug info?
Kansas and Ohio/Midwest scenery development.
KEQA, 3AU, KRCP Airport Layout
Intel i7/GeForce RTX 2070/Max-Q
User avatar
wlbragg
 
Posts: 7587
Joined: Sun Aug 26, 2012 12:31 am
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/RTX 2070

Re: Please test shuttle against "next"

Postby Thorsten » Sun May 03, 2020 11:27 am

Actually that's Richard's code - he did the basic framework for the MFD/button wirings.
Thorsten
 
Posts: 12490
Joined: Mon Nov 02, 2009 9:33 am


Return to Spaceflight

Who is online

Users browsing this forum: No registered users and 3 guests