Space Shuttle - Bugfixes

[wlbragg]

I just found some of the panel base that the normals were screwed up on. On the Aft Right RCS Tank isolation switch base (the red base the switch rocks on) were flipped wrong. So it is beyond the switches. For that part I think it would be easiest for me to do one panel base at a time and just select it all and recalc the normal outside. That is what I did for O7 and it looks correct.

Also there was a typo in the switch name (only in the effect definition section) on right-rcs-tank-isol-a-345 and right-rcs-tank-isol-b-345 which caused those switches to be outside the effects definition. I remember fixing something similar before and it got reverted or it was different switches.

[eatdirt]

@wlbragg, yes, I am seeing more now, I let you know if other switches are problematic after a snapshot to latest devel of fgspaceshuttle.

However, I start knowing my cockpit now, and I am 100% sure the switches were fine before, so that is a certainly a regression. On my side, I've also switched from fg 2018.2.2 to 2018.3.1, so this may possibly be another reason that triggered the problem?

Thanks for the fixes, quite a lot of work!
Cheers,
Chris.

[eatdirt]

Hi guys,
it seems to me that we might have a sort of transient issue with the payload retention system. Sometimes, I just cannot release the latches, they remain locked, although I am pretty sure I am doing the same chain of actions, namely switching on power for the payload bay and switching one payload retention logic before the latches. When they're locked, even with the menu nothing happens, they just remain locked. I actually remember someone mentioning this issue as well, I now think it is real, but hardly reproducible

Let's keep an eye on that maybe.

Cheers,
Chris.

[Richard]

Arrrrg, this is fairly extensive. @Thorsten, any clue as to what might have happened here? These are all individual switches, they don't simply change at will! Either it was that way since the beginning and we somehow didn't notice or something changed them.

likely to be a consequence of switching to single sided surfaces - I've certainly had to flip normals quite a lot after doing this.

[wlbragg]

Thanks Richard, that'd be it most certainly. That explains why @eatdirt recalls this as being a relatively new issue. Lesson learned. It's not that difficult to fix on panel that are not split out yet, only on the individual switches. I listed the finished panels and they are pushed. So if anyone is looking for more, look only at the rest of the detailed mesh.

[wlbragg]

On some panels it's a little more involved because recalculating outside doesn't fix some of the normals that actually need to be flipped. What a pain, I guess I should listen to Thorsten when he says to keep it simple and let well enough alone.

It's not that much work, just time I could be doing something a little more constrictive.

[wlbragg]

Already completed (unless I missed something).
You can double check after I push the corrections. I'll notify you when I push anything and what it is I pushed.
This is for the benefit of anyone not following along in GIT and is helping to locate the normal issues.

O1 - pushed
O2 - pushed
O3 - pushed
O5 - pushed
O6 - pushed
O7 - pushed
O8 - pushed
O9 - pushed
O13 - pushed
O14 - pushed
O15 - pushed
O16 - pushed
O17 - pushed
L10 - pushed
L11 - pushed
L12 - pushed
R11 - pushed
R12 - pushed
R14 - pushed

If anyone could look over these completed panels closely and verify I got everything, that would be a tremendous help.

All that should be left is the aft wall, if there is any issues on those panels.

[wkitty42]

I guess I should listen to Thorsten when he says to keep it simple and let well enough alone.

yabut if you had, the craft wouldn't be as awesome as it is

[GinGin]

Everything looks fine thanks
I will have another look to be sure.

Just noticed one thing, the writing a bit curved

[Thorsten]

Just noticed one thing, the writing a bit curved

It actually is the same in the Gigapan from which we extracted the textures... I suspect it's a stitching artifact and not a feature though.

[wlbragg]

I suspect it's a stitching artifact and not a feature though.

I noticed it as well, I'll straighten it up.

EDIT:
Turned out it was the uv layout not the legend itself. It is still a bit crooked but about as good as it is going to get without breaking the mesh down.

[legoboyvdlp]

wlbragg, do these switches need fixed too?


It's the payload bay floodlight switches.

[wlbragg]

Looks like it, I take a look, thanks.

[eatdirt]

Happy new year to all, thank you Wayne for all the cockpit fixes and new textures, very nice!

Just noted these warning messages in the console with fg 2018.3.1 and latest git snapshot for fgspaceshuttle (08/01/2019).

Could not find at least one of the following objects for animation: 'O8-covers'
Could not find at least one of the following objects for animation: 'O8-covers'

I've also noticed that the "velcro fur" is gone, its texture now looks as before the "Velcro visuals" were added. Anyone else seeing this?

Cheers,
Chris.

[wlbragg]

@eatdirt
I forgot to un-hide the covers after some recent work I did on the on the O8 mesh.

Your right, the fir shader is not working on the velcro. I don't see how it was something i could have caused as it was an effect I didn't touch, but I suppose it's possible. I'll investigate it and see if I can figure out what happened to it.

@legoboyvdlp
I fixed the normal on the payload bay light switches, thanks for catching it and letting me know.