Board index FlightGear Development Spaceflight

Space Shuttle - Bugfixes

Discussion about development and usage of spacecraft

Space Shuttle - Bugfixes

Postby Thorsten » Tue Dec 04, 2018 8:21 am

Use this thread to report (suspected) bugs and for discussing fixes.

When reporting a bug, be as concise as possible in the steps that need to be taken to reproduce it. Report any suspicious log or console messages as well as what you expect to happen and what happens instead.

Always indicate what version of the Shuttle you're using, where you got it from and what FG version you're using.
Thorsten
 
Posts: 11190
Joined: Mon Nov 02, 2009 8:33 am

Re: Space Shuttle - Bugfixes

Postby GinGin » Thu Dec 13, 2018 9:16 am

Hello,

Not really a bug Shuttle wise, more linked to the wiki.
Thumbnails semm to have dissapeared :

Image


Image
GinGin
 
Posts: 802
Joined: Wed Jul 05, 2017 10:41 am
Location: Paris
Callsign: Gingin

Re: Space Shuttle - Bugfixes

Postby wkitty42 » Fri Dec 14, 2018 10:54 pm

already taken care of... it was a file system problem that has been corrected... the thumbnails will be regenerated and reappear automajikally ;)
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 5757
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 14.04.5

Re: Space Shuttle - Bugfixes

Postby eatdirt » Tue Dec 18, 2018 11:10 pm

Hi there, my last trip at 4000nm with FG 2018.3.1 and the spaceshuttle (dev-branch) might have affected my vision and/or damaged my brain :roll:

It looks to me that some switches on the top panel are actually twisted :shock:

Look at the left and right RCS crossfeed switches (the others above are fine). Notice on the far right the same issues with the OMS crossfeed ones, see later pictures

From the Commander seat:
Image

From the Pilot seat, same conclusion:
Image

Now a big zoom on the OMS crossfeed and tank isolation ones, some looks actually broken too:

Image

To be sure is not a funny light/shadow effect, just above, the He supply valves look fine:

Image

May someone could confirm I am not totally crazy?

Cheers,
Chris.
eatdirt
 
Posts: 379
Joined: Wed Aug 15, 2018 2:06 pm

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 12:23 am

Your not crazy, looks like normals got flipped. I'll take a closer look in the next day or two.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby eatdirt » Wed Dec 19, 2018 9:30 am

looks like normals got flipped. I'll take a closer look in the next day or two.


Thanks! I think there are others as well, on the O14, O15 and O16 panels, but I don't think we have usable switches there, yet.
eatdirt
 
Posts: 379
Joined: Wed Aug 15, 2018 2:06 pm

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 4:33 pm

@eatdirt I'm looking at the issue now and it's going to take a bit of digging. What I see in your first shots looks like a rotation issues. Except the normals in the blend also look like they are screwed up.

bad normal as they are now
Image

after I recalculated outside
Image
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 4:42 pm

Wow, it is just the normals. That is so weird that flipped normals gives you such a 3dimentional brain fart. I corrected the first switch and looked at it in the sim, it is fixed and the rest I can verify are tweaked in my version as well. It'll take a bit of time to sort it out and get all the offending mesh fixed. After I notify you of my first round of corrections maybe you can keep an eye out for any I missed or anything we haven't noticed yet.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 4:53 pm

Arrrrg, this is fairly extensive. @Thorsten, any clue as to what might have happened here? These are all individual switches, they don't simply change at will! Either it was that way since the beginning and we somehow didn't notice or something changed them. :evil:
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 4:55 pm

I just did two rows of manifold isolation and every other one was flipped...
Last edited by wlbragg on Wed Dec 19, 2018 5:03 pm, edited 1 time in total.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 5:02 pm

OK, GPC/MDM panel left of RCS has many normal issues and it never was split out. So this is inherited from the original mesh and we simply never noticed it. This could literally be happening anywhere in the cockpit. Keep an eye out.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 5:05 pm

This is the less noticeable thing to watch for. Sorry we were in the dark and I had to use the lights to see. Looking straight on it's not as easy to see.

before
Image

after
Image
Last edited by wlbragg on Wed Dec 19, 2018 5:19 pm, edited 1 time in total.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 5:11 pm

I also noticed most every switch has an unneeded face at the bottom of it, Thorsten, I think I already know the answer but, enough gain to make it worthwhile to delete the unneeded face?
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 5:24 pm

If anyone wants to help identify the bad normals feel free to search in the sim. It is actually easier to see in the sim than in the blend. If you find more please be specific as to the panel and row, or even the individual switch. Again, in the blend, I have to click on the offending object, set it to edit, select all faces, click on the view normal switch and then recalculate outside to fix if it is wrong. I have to do these steps for every object just to see if it is wrong. Without looking closely at the normal vectors, I can't even really tell after taking all those steps. So by then I just recalculate outside and see if the vector lines changed before I know if they were screwed up in the first place.
Thanks eatdirt for finding this, "NOT", :D
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Re: Space Shuttle - Bugfixes

Postby wlbragg » Wed Dec 19, 2018 5:35 pm

Already completed (unless I missed something).
You can double check after I push the corrections. I'll notify you when I push anything and what it is I pushed.
This is for the benefit of anyone not following along in GIT and is helping to locate the normal issues.

O1 - pushed
O2 - pushed
O3 - pushed
O5 - pushed
O6 - pushed
O7 - pushed
O8 - pushed
O9 - pushed
O13 - pushed
O14 - pushed
O15 - pushed
O16 - pushed
O17 - pushed
Last edited by wlbragg on Thu Dec 20, 2018 4:38 am, edited 10 times in total.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
Intel i5 3570K AMDRX480
User avatar
wlbragg
 
Posts: 4988
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Linux/AMDRX480

Next

Return to Spaceflight

Who is online

Users browsing this forum: No registered users and 1 guest

cron