Board index FlightGear Support Tools ATC-pie

[Bug] Crash when deleting a weather station in MP  Topic is solved

ATC-pie is a radar air traffic control simulation program for the FlightGear multi-player network.

[Bug] Crash when deleting a weather station in MP

Postby Progman » Sat Feb 03, 2018 6:49 pm

When you have a weather station added to your game and delete the weather station while in multiplayer, you will get the following error message when the next weather report comes in:

Code: Select all
Traceback (most recent call last):
  File "ATC-pie-1.4.1/game/flightGearMP.py", line 76, in run
    for key in self.known_info:
RuntimeError: dictionary changed size during iteration
Aborted


I believe you have to save the entries to delete in a new list first and iterate over this list instead of iterating over the "self.known_info" list.
Progman
 
Posts: 10
Joined: Sun Dec 17, 2017 7:12 pm

Re: [Bug] Crash when deleting a weather station in MP

Postby mickybadia » Sat Feb 03, 2018 11:06 pm

Thanks for this, I will have a look. I have a similar or related bug report pending so it all should help.
If you care to help further, please backup your settings/ad/XXXX.ini file for a crashed airport and send it to me, then try the same after deleting/moving the file (or at a fresh airport where you have never been before) and report.
Question if fresh airports do NOT crash, and if you can remember: had all crashing locations been opened with earlier versions of ATC-pie?
mickybadia
 
Posts: 368
Joined: Tue Sep 24, 2013 9:12 am

Re: [Bug] Crash when deleting a weather station in MP

Postby Progman » Sun Feb 04, 2018 9:07 am

It does crash with a new airport or with a clean installation. Reproduce with:

  • Open any airport (probably one which has METAR information), like LEMD
  • Join Multiplayer
  • Add an additional airport with METAR information to the weather panel, like EDDF
  • Press "Check now"
  • Remove the additional airport EDDF
  • Press "Check now"

It will crash with the error message above.

Tested with git checkout b4f3e894b64fe3c62ad4ff6f0f235bf65fdff4c2.
Progman
 
Posts: 10
Joined: Sun Dec 17, 2017 7:12 pm

Re: [Bug] Crash when deleting a weather station in MP  

Postby mickybadia » Wed Feb 07, 2018 7:53 pm

Easy one.
Sorted and will be pushed in next update.

A shame that such minor issue would make some systems crash. I only had a message in the console but nothing broke...
Anyway thanks for posting. (also consider the SourceForge ticket system for this type of plain bug report)
mickybadia
 
Posts: 368
Joined: Tue Sep 24, 2013 9:12 am


Return to ATC-pie

Who is online

Users browsing this forum: No registered users and 1 guest