Board index FlightGear Support Tools OpenRadar

OpenRadar - Missing Taxiways & Parking Number

OpenRadar is a standalone radar screen which connects to the FlightGear multiplayer servers. It is currently being developed.

OpenRadar - Missing Taxiways & Parking Number

Postby Capt_Jeff » Mon Apr 27, 2020 11:20 pm

I've been noticing that OpenRadar cannot display Taxiways lines and parking numbers for all Airports on the Western and southern hemisphere, despite creating a or downloading the updated groundnet.xml file and placing it under the Openradar's aiport.zip

For example, take a look at KSFO, who has a coodinates of [N37° 37.025, W122° 22.997) Image
(I added Route Text instead, under data->routes->KSFO->KSFO_Text_.xml to show parking number)
But that is not enough.., as all taxiways lines are still missing.

So, i swept through the source code to find out whats the problem. And after sometime i found this method under:
Package: de.knewcleus.openradar.view.groundnet TaxiPoints.java
Image


line 67-73 | What the method is trying to do is, take a Degree and Hour coordinate and convert to degree.decimal coordinate:
W122° 22.997 = -122.383283

if we focus on Line 68; If the Coordinate start with W, S.., the variable sign become -1.

now if we focus on line 72 and assume the method will parse [W122° 22.997], we can see:

(double)sign * degree + minutes / 60
= -1.0 * 122 + 22.997 / 60
= -122 + 0.383283 <- (- +) subtracts rather than join
= -121.6167
correct answer should be -122.383283.

we ended up getting the wrong answer because were adding a positive value to a negative value, which ends up subtracting rather than joining.

The solution is to multiply the minutes by sign(-1) and add brackets.
Image

(double)sign * degree + (sign * minutes / 60)
= -1.0 * 122 + ( -1 * 22.997 / 60)
= -122 - 0.383283 <- (- -) adds
= -121.383283

After Compiling.., we load KSFO and we then see this:
Image
Beautiful isn't it? i have used OpenRadar for over 5 years, and i have never seen KSFO like that. The reason why the taxiways line and parking number didn't appear its because they were being misplaces at a different coordinate for example:
[W122° 22.997] was being place at [-121.6167], instead of the correct coordinate [-121.383283]. that's over 12 miles difference!!!


I have created a fork on the Source-Forge called Capt-jeff-Flightgear, that is a clone of the branch called Flightstrip-Bay for OpenRadar..
But since I'm new to how git works, i don't know how to merge to the original. Any recommendation on what to do next?
Last edited by Capt_Jeff on Tue Apr 28, 2020 9:19 pm, edited 1 time in total.
Capt_Jeff
 
Posts: 9
Joined: Sun Apr 26, 2020 8:59 pm
Callsign: Cap_Jef, ATC_Jef
Version: 2019.1.1
OS: Win10, MacOSX

Re: Bug Found on OpenRadar. Patch included.

Postby WoodSTokk » Tue Apr 28, 2020 3:02 am

setting one parenthesis is enough
Code: Select all
(double)sign * (degree + minutes / 60d)
WoodSTokk
 
Posts: 545
Joined: Tue Oct 17, 2017 2:30 pm
Location: Milky Way/Sol/Earth/Europe
Callsign: OE-WST
IRC name: WoodSTokk
Version: 2020.3.0
OS: Debian Buster

Re: Bug Found on OpenRadar. Patch included.

Postby TeXnicer » Tue Apr 28, 2020 7:37 am

quick mafs XD
could this affect all other airports also? Since I am missing all the taxiways everytime I tried (in Germany) thats roughly about 48°-54° N and 008°-012° E
User avatar
TeXnicer
 
Posts: 20
Joined: Tue Mar 17, 2015 2:39 pm
Callsign: D-EKSW
IRC name: TeXnicer
Version: 2018.3.2
OS: Debian 10

Re: Bug Found on OpenRadar. Patch included.

Postby Michat » Tue Apr 28, 2020 7:21 pm

@TeXNicer I think yes.
User avatar
Michat
 
Posts: 1041
Joined: Mon Jan 25, 2010 6:24 pm
Location: Spain
Version: 191b
OS: GNewSense

Re: Bug Found on OpenRadar. Patch included.

Postby Capt_Jeff » Tue Apr 28, 2020 8:27 pm

TeXnicer wrote in Tue Apr 28, 2020 7:37 am:quick mafs XD
could this affect all other airports also? Since I am missing all the taxiways everytime I tried (in Germany) thats roughly about 48°-54° N and 008°-012° E


If your missing taxiways in N/E hemisphere, like on Germany.., its means your simply missing the ground net xml.

Create one, or Get your groundnet.xml here: http://groundweb.azurewebsites.net/main/Airports then add them to the airport.zip.

For example lets add EDDL's taxiways and parking number..
step1 - we copy\download the EDDL.groundnet.xml http://groundweb.azurewebsites.net/main/Airports/E/D/D/EDDL.groundnet.xml
step2 - we open the airport.zip inside Openradar folder: OpenRadar\data\airport.zip
step3 - We then replace/place EDDL.groundnet.xml inside the airport.zip => Airports/E/D/D/EDDL.groundnet.xml
(ensure to follow the aiport ICAO folder structure)

Thats it.,, done.

If for some reason it didn't load, it means there must have been a parsing error. you can confirm this by looking at OpenRadar console window for any exceptions that contains Groundnet. if thats the case, then examine the EDDL.groundnet.xml for any errors such as :

<Parking index="1" <=Index must never repeat
type="gate"
name="D" <=if name too long
number="53" <=if missing number
lat="N37 37.101"
lon="W122 22.922"
heading="115.799"
radius="30.9576"
airlineCodes="JBU,SWA,VRD"
pushBackRoute="473" <=if none existing nodes
/>

<arc begin="340" <= ensure it starts on a parking node
end="80"
isPushBackRoute="1"
name=""
/>
Capt_Jeff
 
Posts: 9
Joined: Sun Apr 26, 2020 8:59 pm
Callsign: Cap_Jef, ATC_Jef
Version: 2019.1.1
OS: Win10, MacOSX

Re: Bug Found on OpenRadar. Patch included.

Postby Capt_Jeff » Tue Apr 28, 2020 9:18 pm

For those who want to patch OpenRadar issue now, and not edit the source code or wait for a new release.

step 1 - Download My version of TaxiPoint Java class File
http://jeff3d.000webhostapp.com/Permanent_Link/TaxiPoint.class

step 2 - Then open the Openradar.Jar file using a Zip software.

Image

step 3 - Inside the zip navigate to de\knewcleus\openradar\view\groundnet

Image

step 4 - Replace the TaxiPoint.class with the one that I've provide in the link above.



Done.
Capt_Jeff
 
Posts: 9
Joined: Sun Apr 26, 2020 8:59 pm
Callsign: Cap_Jef, ATC_Jef
Version: 2019.1.1
OS: Win10, MacOSX

Re: OpenRadar - Missing Taxiways & Parking Number

Postby jomo » Fri Jun 12, 2020 9:10 am

Thx Cap_Jeff for that work
BUT: Could it be that works only for WINDOWS systems?
I tried - but afterward my OpenRadar did not start complete - I am on UBUNTU!
rgds
jomo / ATCjomo + EDDFjo1 + EDDFjo2
ATC at EDDF Fr,Sa,Su,We from 20:00 to 24:00 CET/MEZ., see http://www.emmerich-j.de
User avatar
jomo
 
Posts: 957
Joined: Thu Feb 12, 2009 6:46 pm
Location: Mainz, Germany
Callsign: jomo jomoATC
OS: UBUNTU 18.4


Return to OpenRadar

Who is online

Users browsing this forum: No registered users and 1 guest