Board index FlightGear Release candidates

Console Error Msg: Digital Filter Absolute Value

Release candidate testers are encouraged to post their feedback here. Please read the introduction topic for details.
Forum rules
Please read the introduction topic for details.

Re: Console Error Msg: Digital Filter Absolute Value

Postby Alant » Mon Apr 03, 2023 10:41 pm

I see it on all aircraft that I have tried - 707, and my VC10 and TSR2 WIPs.
Alant
 
Posts: 1219
Joined: Wed Jun 23, 2010 6:58 am
Location: Portugal
Callsign: Tarnish99
Version: latest Git
OS: Windows 10/11

Re: Console Error Msg: Digital Filter Absolute Value

Postby polly » Mon Apr 03, 2023 11:28 pm

OK Tks for that. With the breakpoints noted above I can at least see the pathname of the file being parsed immediately before the error logs. Tracing through the parsing process will be a different kettle of offal.
User avatar
polly
 
Posts: 956
Joined: Thu Nov 04, 2010 3:45 pm

Re: Console Error Msg: Digital Filter Absolute Value

Postby Alant » Mon Apr 03, 2023 11:31 pm

Does this filter actually work in an autopilot?
Perhaps we should hand it back to the original author now we know that it is to blame for the error message.
Alant
 
Posts: 1219
Joined: Wed Jun 23, 2010 6:58 am
Location: Portugal
Callsign: Tarnish99
Version: latest Git
OS: Windows 10/11

Re: Console Error Msg: Digital Filter Absolute Value

Postby polly » Tue Apr 04, 2023 10:18 am

Well, I didn't expect to find the navselector in any of the models you mentioned, or in the UFO. We see the error message point to either <absolute> or <value> tags and point to coherent-noise filter and to gain filter. I thought it worth stepping through the initialisation of a failing filter to try to see if it's a general failure in proprule initialisation.
User avatar
polly
 
Posts: 956
Joined: Thu Nov 04, 2010 3:45 pm

Re: Console Error Msg: Digital Filter Absolute Value

Postby wkitty42 » Tue Apr 04, 2023 2:21 pm

carry on, polly! you may find the actual problem and provide a fix before anyone else can :)
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 9146
Joined: Fri Feb 20, 2015 4:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: Console Error Msg: Digital Filter Absolute Value

Postby polly » Tue Apr 04, 2023 2:35 pm

I'm beginning to wonder. I can't see the error with the UFO that mariuszXC is getting and single stepping causes the code to barf ( technical term for segfaulting ) during the xml read.
I've tried git bisecting but anything earlier than 2023 seems unable to build, ( something something std::mutex )
On to hedge hopping with the TSR-2, that travesty of policy still hurts.

Edit
For the 707: I don't see these errors. These:
Code: Select all
 0.48 [ALRT]:terrain    Unexpected property in listener /sim[0]/rendering[0]/static-lod[0]/detailed[0]
    0.48 [ALRT]:terrain    Unexpected property in listener /sim[0]/rendering[0]/static-lod[0]/rough-delta[0]
    0.48 [ALRT]:terrain    Unexpected property in listener /sim[0]/rendering[0]/static-lod[0]/bare-delta[0]


are different, I see them on all A/C in next and have raised a ticket for this issue.

VC10 Same, cannot see this particulare error message, just the LOD listener as 707 above

BAC-TSR2 ditto, only the LOD listener

That all brings me back to the only culprit seems to be navselector.xml; I wonder if it's to do with picking up alii from a separate parameter file ?
User avatar
polly
 
Posts: 956
Joined: Thu Nov 04, 2010 3:45 pm

Re: Console Error Msg: Digital Filter Absolute Value

Postby Alant » Tue Apr 04, 2023 4:26 pm

Could it be Fgdata "Ground shaking effect" by Stuart Buchanan on 30/12/20, ?
This has connected changes in g-forces.xml, defaults.xml and cockpit-view.xml.
Alant
 
Posts: 1219
Joined: Wed Jun 23, 2010 6:58 am
Location: Portugal
Callsign: Tarnish99
Version: latest Git
OS: Windows 10/11

Re: Console Error Msg: Digital Filter Absolute Value

Postby polly » Tue Apr 04, 2023 8:18 pm

@alant , Yes, thanks, I'd forgotton I had deleted the g-forces reference locally while I was tracing navselector.

I sourced a couple of tickets, one to do with the LOD listener error messages and one for this issue:

It doesn't actually say, in the wiki, that <input> stanza may contain anything other than a simple property and, indeed, tracing throgh the configuration calls it looks to me as if there's support for conditions, values etc inside the <enable> stanza but not for the <input> stanza.

I'll look forward to any replies on the ticket but it looks like, "If it hurts when we do this" we shouldn't do it; perhaps g-forces.xml and navselector.xml need rethinking. Thanks, hupeoples (!) for all the help.
User avatar
polly
 
Posts: 956
Joined: Thu Nov 04, 2010 3:45 pm

Re: Console Error Msg: Digital Filter Absolute Value

Postby polly » Wed Apr 05, 2023 2:21 pm

The ticket https://sourceforge.net/p/flightgear/codetickets/2801/ has an answer, it suggests navselector.xml needs a re-do. I cannot see who is the author, is that Stuart ? The same applies to g-forces.xml regarding the <absolute-value> tag , I suppose.
User avatar
polly
 
Posts: 956
Joined: Thu Nov 04, 2010 3:45 pm

Re: Console Error Msg: Digital Filter Absolute Value

Postby MariuszXC » Fri Apr 21, 2023 12:32 pm

There is a little more to that. I tried to submit a fix via SourceForge, but its servers seem to be barfing at me at the moment... So here it is, a one-liner actually. It fixes the cause for 'unknown config node absolute' message from Autopilot.

Code: Select all
diff --git a/src/Autopilot/digitalfilter.cxx b/src/Autopilot/digitalfilter.cxx
index a79e057da..5ca7bbb0f 100644
--- a/src/Autopilot/digitalfilter.cxx
+++ b/src/Autopilot/digitalfilter.cxx
@@ -839,6 +839,7 @@ bool CoherentNoiseFilterImplementation::configure(SGPropertyNode& cfg_node,
 
     if (cfg_name == "absolute") {
         _absoluteVal = cfg_node.getBoolValue();
+        return true;
     }
     return false;
 }
INOP
MariuszXC
 
Posts: 1061
Joined: Tue May 18, 2021 5:38 pm
Location: Europe
Callsign: SP-MRM
Version: 2020.4
OS: Ubuntu 16.04

Re: Console Error Msg: Digital Filter Absolute Value

Postby xDraconian » Fri Apr 21, 2023 3:47 pm

This has been merged. Thanks @MariuszXC
xDraconian
 
Posts: 406
Joined: Sun Jan 21, 2018 6:53 am
Version: Git
OS: Linux Mint

Re: Console Error Msg: Digital Filter Absolute Value

Postby MariuszXC » Fri Apr 21, 2023 4:03 pm

Great and apologies if there are multiple merge requests. Me and Sourceforge servers didn't have a good time together today.
INOP
MariuszXC
 
Posts: 1061
Joined: Tue May 18, 2021 5:38 pm
Location: Europe
Callsign: SP-MRM
Version: 2020.4
OS: Ubuntu 16.04

Previous

Return to Release candidates

Who is online

Users browsing this forum: No registered users and 4 guests