Board index FlightGear The FlightGear project

Contributing to FlightGear  Topic is solved

Questions about the FlightGear organisation, website, wiki etc.

Re: Contributing to FlightGear

Postby Philosopher » Fri Nov 21, 2014 2:35 am

Thanks,
Philosopher
(inactive but lurking occasionally...)
Philosopher
 
Posts: 1590
Joined: Sun Aug 12, 2012 6:29 pm
Location: Stuck in my head...
Callsign: AFTI
Version: Git
OS: Mac OS X 10.7.5

Re: Contributing to FlightGear

Postby ludomotico » Fri Nov 21, 2014 2:58 pm

The code is in Common.sh https://gitorious.org/fg/getstart/sourc ... /Common.sh and it seems pdflatex is called only once. I think the loop is not correct, but I need some more coffee:

Code: Select all
buildpdf () {
CYCLE=1
while [ ${CYCLE} -ne 2 ]; do
${PDFLATEX} ${SOURCE}\.tex
CYCLE=`expr ${CYCLE} + 1`
done
if [ ${SOURCE} != "FGShortRef" ]; then
makeindex ${SOURCE}
${PDFLATEX} ${SOURCE}\.tex
fi
}


CYCLE is initialized to 1. It is not equal 2, so the loop is entered, pdflatex is run, then CYCLE++ (now, CYCLE==2)... and the loop exits after only one pass!

I think the intention was "-ne 3" as the condition of the while, or initializing CYCLE=0. But even a "-ne 4" won't hurt.

In any case, using a loop just to run a command twice seems a good way to obfuscate a code :)
User avatar
ludomotico
 
Posts: 1026
Joined: Tue Apr 24, 2012 1:01 pm
Version: git
OS: Debian GNU/Linux

Re: Contributing to FlightGear

Postby twingemini1959 » Thu Jan 15, 2015 12:03 am

This is my modded bo105, as flown by me, zippy:
https://www.dropbox.com/sh/bigjpura3384 ... IrQ-a?dl=0

You will see the zipped file....let me know if it works!
twingemini1959
 
Posts: 1
Joined: Wed Jan 14, 2015 2:18 am

Re: Contributing to FlightGear

Postby stuart » Thu Jan 15, 2015 5:34 pm

Hi Guys,

Well spotted on the script bug. I'll update the getstart git repository tonight.

-Stuart
G-MWLX
User avatar
stuart
Moderator
 
Posts: 1474
Joined: Wed Nov 29, 2006 9:56 am
Location: Edinburgh
Callsign: G-MWLX

Previous

Return to The FlightGear project

Who is online

Users browsing this forum: No registered users and 1 guest