Board index FlightGear Development Aircraft

A320-family development

Questions and discussion about creating aircraft. Flight dynamics, 3d models, cockpits, systems, animation, textures.

Re: A320-family development

Postby CaptB » Tue Oct 29, 2019 2:04 pm

The moment any new property is set in the eff, which works from the property browser is tied to any other in the a320-lights.xml where the logic for the dc-ess and dc-1 is tested it stops responding. This suggest either the logic is flawed or the a problem with the dc bus, but looking at the property browser it seems fine. I just don't understand.
CaptB
 
Posts: 600
Joined: Thu May 23, 2013 6:36 pm
Callsign: EKCH_AP
IRC name: CAPTB
Version: 2020.1.1
OS: Xubuntu 20.04

Re: A320-family development

Postby Thorsten » Tue Oct 29, 2019 2:18 pm

How is it tied (how does the relevant code look like)?
Thorsten
 
Posts: 11720
Joined: Mon Nov 02, 2009 8:33 am

Re: A320-family development

Postby CaptB » Tue Oct 29, 2019 2:48 pm

From the a320-lights.xml with a custom property(used a different knob here to see if it changed anything):

Code: Select all
   <switch name="/controls/lighting/temporary">
         <default value="0" />
         <test logic="OR" value="/controls/lighting/overhead-panel-knb">
            /systems/electrical/bus/dc-ess gt 25
            /systems/electrical/bus/dc-1 gt 25
         </test>
      </switch>
CaptB
 
Posts: 600
Joined: Thu May 23, 2013 6:36 pm
Callsign: EKCH_AP
IRC name: CAPTB
Version: 2020.1.1
OS: Xubuntu 20.04

Re: A320-family development

Postby legoboyvdlp » Tue Oct 29, 2019 3:08 pm

This suggest either the logic is flawed or the a problem with the dc bus, but looking at the property browser it seems fine. I just don't understand.


I verified myself that the dc properties are both greater than 25.

I also don't understand why it would work on one system and not another...
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby legoboyvdlp » Tue Oct 29, 2019 3:23 pm

Pushed new FWC Phase logic and the new memos; please report any errors you spot! I've spent the last while checking it but still may have missed some.
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby Thorsten » Tue Oct 29, 2019 3:38 pm

From the a320-lights.xml with a custom property(used a different knob here to see if it changed anything):


Ah, it's literally a tied property - then (almost) everything is clear.

Tied properties don't usually update in the effect framework (because they're tied properties and never trigger listeners) - we pass all those cases in the Shuttle through trivial property rules (which basically have a gain factor of 1) to 'untie' them before they reach lights. in the effect definitions

There may have been some effort to 'untie' properties in more recent FG binaries which is why it might work for Jonathan - but the fact that this works is more surprising than the fact that it does not.
Thorsten
 
Posts: 11720
Joined: Mon Nov 02, 2009 8:33 am

Re: A320-family development

Postby legoboyvdlp » Tue Oct 29, 2019 3:47 pm

That's good to know -thanks - so just to confirm, would this do the same thing as the property rule:

<switch name="lights/panel-light">
<output>/controls/lighting/panel-light</output>

<default value="0" />
<test logic="OR" value="/controls/lighting/main-flood-knb">
/systems/electrical/bus/dc-ess gt 25
/systems/electrical/bus/dc1 gt 25
</test>
</switch>
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby Thorsten » Tue Oct 29, 2019 4:23 pm

No - you have to pass it through something that's not JSBSim to generally create an untied property. It's silly and annoying, but that's how it is.
Thorsten
 
Posts: 11720
Joined: Mon Nov 02, 2009 8:33 am

Re: A320-family development

Postby legoboyvdlp » Thu Oct 31, 2019 7:04 pm

Pushed a set of bugfixes:
  • Improvements to recall system; will show NORMAL if nothing recalled
  • Improvements to T.O INHIBIT / LDG INHIBIT - removed with RCL and 3 second delay
  • Galleys now powered - oops!
  • Electrical fault messages added
  • ELEC EMER CONFIG no longer shows after clearing DUAL FAILURE
  • Major improvement to takeoff power logic - now works properly with FLX / TOGA and works with TLA, not thrust
  • FWC phases disabled by replay being active

I have some bugfixing requests as I tried something I never tried before and used die() for error checking - basically if something stops working and you see a similar message to this one let me know as soon as possible:
Exception in ECAM-phases.nas, line 271


Next on the list is fixing the flood lights. It's hard when you don't see the bug yourself!
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby legoboyvdlp » Fri Nov 01, 2019 8:55 am

Mapstructure is broken on the A320-family; I need to identify and correct this error. I will investigate it but it doesn't look like the old error...
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby Thorsten » Fri Nov 01, 2019 9:45 am

Next on the list is fixing the flood lights. It's hard when you don't see the bug yourself!


We have diagnosed it and I am 90% confident in my analysis.

Look into the Shuttle's

Systems/ssme-flame-computations.xml

(which is a property rule file rather than JSBSim) and you'll find plenty of

Code: Select all
 <filter>
   <type>gain</type>
   <gain>1.0</gain>
   <input>/fdm/jsbsim/systems/various/ssme-flame-collimation</input>
   <output>/sim/systems/various/ssme-flame-collimation</output>
 </filter>


whose only purpose is to make the output of a JSBSim function palatable to the effect system. The surprise is not that it fails for many people, the surprise really that it does not fail for you.
Thorsten
 
Posts: 11720
Joined: Mon Nov 02, 2009 8:33 am

Re: A320-family development

Postby legoboyvdlp » Fri Nov 01, 2019 10:09 am

I just did that and it seems to work for CaptB - so thank you very much!

Unfortunately we have a strange error in Mapstructure again - I found a bug where I am not sure how it managed to work before as it was calling setScale but passing only one argument. I'll see if that fixed it.

Also in the process of implementing the air data computer - I really like JSBSIM's <sensor> element...

Edit - ok, yes, fixing the setScale fixed that error, but it seems that the FIX and NDB layers are now inoperative... does it ever end?

Edit 2 - and the issue turns out to be the setScale() code that I used to improve performance (only calling setScale when needed increased performance by 10% for me...) - but I didn't realize that passing just one argument would mean that it would use the same for both x and y.
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby legoboyvdlp » Fri Nov 01, 2019 11:12 am

MapStructure should be fixed; sorry about that.
User avatar
legoboyvdlp
 
Posts: 7750
Joined: Sat Jul 26, 2014 1:28 am
Location: Northern Ireland
Callsign: G-LEGO
Version: next
OS: Windows 10 HP

Re: A320-family development

Postby linux&os2 » Mon Nov 04, 2019 11:28 am

Hi, flying at speed above 350 kts aircraft starts to climb fast with joystick in rest pos.
Happens in manual throttle.
linux&os2
 
Posts: 19
Joined: Wed Feb 21, 2018 11:18 am
Location: Belgium Zedelgem
Version: V2019.1.2
OS: Linux gentoo

Re: A320-family development

Postby merspieler » Mon Nov 04, 2019 11:39 am

That's correct. It is the overspeed protection that kicks in.
If everything is going against you, keep in mind that airplanes take off against the wind, not with it.
merspieler
 
Posts: 719
Joined: Thu Oct 26, 2017 10:43 am
Location: Wish to be in YBCS
Callsign: JST935. ORI1711
IRC name: merspieler
Version: next
OS: Debian Bullseye

PreviousNext

Return to Aircraft

Who is online

Users browsing this forum: Bing [Bot] and 5 guests