I would still suggest to tread carefully with this - the way this is implemented, it's going to break again, it would have to use a variable (property) to look up the cycle dynamically.
Besides, depending on external web-services makes future fgfs releases much less self-contained obviously, just like Thorsten stated originally (imagine downloading fgfs 2018.1 5 years from now - these features won't work at all).
That being said, unless I am missing something (e.g. because there is an explicit exception granting us the corresponding rights), the way we (that is, Phi/fgfs) is making access to their API, also seems very likely to be a violation of their terms of use, which state explicitly:
http://vfrmap.com/map_api.htmlVFRMap.com wrote:Terms- Chart images are required to be clickable links to our site (see examples below).
- Links to VFRMap.com should open in a full browser window including the location (url) bar. Please do not embed our pages in iframes.
- If you anticipate sending significant traffic our way (more than 100 requests per day), please let us know first by emailing api@vfrmap.com.
- We reserve the right to modify or discontinue this API at any time.
- The accuracy of data served via the API is not guaranteed. Please make sure your users understand this.
- This API is the only permitted method of embedding VFRMap data on third party sites. Hotlinking, mirroring, or bulk downloading of map tiles, AFD sections, and other data is prohibited.
(applicable terms highlighted by me)
Given the legal turmoil surrounding fgmembers, the Honda jet and other controversial developments, I find it a little surprising that we're seeing such features added without clarifying whether a corresponding exemption exists or not (as in, linking to it, and adding it to the commit logs).
Especially because this is not some 3rd party Nasal module developed/distributed by some random forum user hiding behind a nickname, but a part of the core fgfs infastructure, developed and maintained by someone who is listed as project admin at sourceforge and elsewhere.
Let's keep in mind, that this is dating back to 2014:
https://sourceforge.net/p/flightgear/fg ... 6dbc72883/the fgdata commit logs wrote:commit 1e0d4f83dc8eafc558fb6115941a2776dbc72883
Author: Torsten Dreyer <---->
Date: Tue Oct 7 23:19:09 2014 +0200
browser map: add vfrmap.com overlay
(back in the early days of the project, such permissions/contributions would have been highlighted in $FG_ROOT/Thanks, but I don't seem to find VFRMap.com being mentioned there at all)