Board index FlightGear Support Multiplayer

P51 burning over the MP

Trouble getting online, setting up a server?
Forum rules
In order to help you, we need to know a lot of information. Make sure to include answers to at least the following questions in your initial post.

- what OS (Windows Xp/Vista, Mac etc.) are you running?
- what FlightGear version do you use?
- copy&paste your commandline.

Please, also see Requesting Technical Help.

Note: If you did not get a reponse, even after 7 days, you may want to check out the FlightGear mailing lists to ask your question there.

P51 burning over the MP

Postby OK-F » Sat Mar 31, 2018 5:57 pm

Hi

I was flying P51 to EDDF the other day and jomo reported that the plane is in fire. I didn't see any fire on my screen. I didn't crash the plane prior to that. Wildfire setting was switched off (share over the MP).
Can someone help with that? thx
OK-F
 
Posts: 48
Joined: Mon Mar 26, 2018 12:26 am

Re: P51 burning over the MP

Postby wkitty42 » Sun Apr 01, 2018 10:01 am

one of the properties being transmitted over MP is being misread as the craft being on fire... whatever code in the craft that catches that property and turns on the fire is where you need to look... that's about as generic as it can get... it could be a simple typo...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 4895
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 14.04.5

Re: P51 burning over the MP

Postby OK-F » Sun Apr 01, 2018 11:27 pm

Thx for the answer however I'm not a developer and don't know what to do.. I'm sure there are people who could help with that right?
OK-F
 
Posts: 48
Joined: Mon Mar 26, 2018 12:26 am

Re: P51 burning over the MP

Postby wkitty42 » Mon Apr 02, 2018 9:42 pm

there should be, yes... if one happens to come along and decide to fix the problem, that will be great! we are all volunteers here ;)
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 4895
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 14.04.5

Re: P51 burning over the MP

Postby OK-F » Tue Apr 03, 2018 7:05 am

I know I'm not new to FG community. Hopefully we can find someone.
OK-F
 
Posts: 48
Joined: Mon Mar 26, 2018 12:26 am

Re: P51 burning over the MP

Postby wlbragg » Tue Apr 03, 2018 3:12 pm

I'm doing some guessing here but looking at the smoke code for the p51, if we're taking the same aircraft and version it looks to be using the newer MP protocol.
Code: Select all
<condition>
            <not>
                <property>sim/multiplay/generic/bool[25]</property>
            </not>
        </condition>

Where we have bool's available. It may be aircraft not using the new protocol will not interpret the MP signals correctly?

EDIT:
Does it show up as burning to another up -to-date P51?
Last edited by wlbragg on Tue Apr 03, 2018 7:09 pm, edited 1 time in total.
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
User avatar
wlbragg
 
Posts: 4278
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Debain/nVGT640

Re: P51 burning over the MP

Postby wlbragg » Tue Apr 03, 2018 3:27 pm

After testing this in MP it does have several warnings about excluding visibility from the aircraft using the older MP protocol!
Kansas(2-27-15)/Ohio/Midwest scenery development.
KEQA (2-27-15), 3AU, KRCP Airport Layout
User avatar
wlbragg
 
Posts: 4278
Joined: Sat Aug 25, 2012 11:31 pm
Location: Kansas (Tornado Alley), USA
Callsign: WC2020
Version: next
OS: Win10/Debain/nVGT640

Re: P51 burning over the MP

Postby OK-F » Tue Apr 03, 2018 5:36 pm

@wlbragg: I'm using the one from FG directory I guess it's the latest version. We can test it let me know when you have time..
Last edited by bugman on Wed Apr 04, 2018 6:03 am, edited 2 times in total.
Reason: Please do not quote entire lengthy posts, instead use @username or similar.
OK-F
 
Posts: 48
Joined: Mon Mar 26, 2018 12:26 am

Re: P51 burning over the MP

Postby Richard » Wed Apr 04, 2018 4:47 am

wlbragg wrote in Tue Apr 03, 2018 3:12 pm:I'm doing some guessing here but looking at the smoke code for the p51, if we're taking the same aircraft and version it looks to be using the newer MP protocol.
Code: Select all
<condition>
            <not>
                <property>sim/multiplay/generic/bool[25]</property>
            </not>
        </condition>



To work compatibly the logic should be the other way around; i.e. the aircraft should set bool[25] (or another bool) when on fire; as the bools default to false.
Richard
 
Posts: 646
Joined: Sun Nov 02, 2014 10:17 pm
Version: Git
OS: Win10

Re: P51 burning over the MP

Postby OK-F » Thu Apr 05, 2018 8:23 pm

We now made a test with V12 and he did not see any fire. He took a different plane and then we took both P51 and I neither him did not see any fire at all.
Last edited by OK-F on Thu Apr 05, 2018 9:33 pm, edited 1 time in total.
OK-F
 
Posts: 48
Joined: Mon Mar 26, 2018 12:26 am

Re: P51 burning over the MP

Postby Richard » Thu Apr 05, 2018 8:30 pm

I've fixed it now; the launcher version will be updated in the next day or so. You can get it from FGAddon now.
Richard
 
Posts: 646
Joined: Sun Nov 02, 2014 10:17 pm
Version: Git
OS: Win10

Re: P51 burning over the MP

Postby wkitty42 » Thu Apr 05, 2018 8:54 pm

@Richard: was it related to the new MP protocol changes?
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 4895
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 14.04.5

Re: P51 burning over the MP

Postby Richard » Thu Apr 05, 2018 10:21 pm

@Wkitty42 - yes[1]. It's slightly bad use of the bools - as ideally the "normal state" of any MP variable should be 0 or nil; as that way if the property isn't transmitted it will leave the airplane in a normal state.

In this case bool[25] is in fact "engine servicable"; i.e. non zero if all is ok. If the property doesn't get transmitted then the value will be 0 or nil; which will be interpreted as "engine is on fire".

It should be standard practice to ensure that multiplayer properties have the normal state as 0 or nil - as that is the most resilient way to implement this.

------------------
[1] 2017.2+ running with 2017.2+ should be fine; but earlier versions of the protocol didn't have bools.
Richard
 
Posts: 646
Joined: Sun Nov 02, 2014 10:17 pm
Version: Git
OS: Win10

Re: P51 burning over the MP

Postby wkitty42 » Thu Apr 05, 2018 10:47 pm

excellent find! i would guess that maybe, with the older protocol, they did something similar like other craft and used an int to send the value and converted it on the other end... i know of several craft that did/do that... i think there was also one that was packing bools into ints using bits for the bools so they could carry eight bools at a time if needed... some of them should be changing over to the new protocol and sending the actual bools instead of ""abusing"" ints as bools...

defaulting to zero or nil for default is definitely a GoodThing<tm> to know... it will make the MP packets a bit smaller since it doesn't have to be transmitted unless it is flipped...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 4895
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 14.04.5

Re: P51 burning over the MP

Postby V12 » Fri Apr 06, 2018 5:19 am

Good idea. But this is not answer why yesterday tests was without fire and smoke. First tests was on only my PC with 2 FG sessions (Concorde and P51D, then P51D and P51D), next test with OK-F (my Concorde and OK-F's P51D, then my 51D and OK-F's P51D), all flawless. Again no fire, no smoke. My Concorde version was good known as MP troublemaker, but now, I hope all MP bugs has been fixed.
Fly high, fly fast - fly Concorde !
User avatar
V12
 
Posts: 749
Joined: Thu Jan 12, 2017 4:27 pm
Location: LZIB
Callsign: BAWV12

Next

Return to Multiplayer

Who is online

Users browsing this forum: No registered users and 2 guests