Board index FlightGear Development AI Traffic

What traffic files are you doing

Intelligent, computer controlled vehicles that drive/fly over the planet!

Re: What traffic files are you doing

Postby wkitty42 » Sun Jul 05, 2020 4:40 pm

i have an account there, too ;)

but i think i'll try it with one of KCLT or KRDU soon-ish...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby wkitty42 » Tue Jul 07, 2020 4:51 am

i found a bad craft radius in AI/Traffic/S/SAS.xml line 2042... should be 12 instead of 127...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby BecOzIcan » Tue Jul 07, 2020 6:18 am

wkitty42 wrote in Tue Jul 07, 2020 4:51 am:i found a bad craft radius in AI/Traffic/S/SAS.xml line 2042... should be 12 instead of 127...


Will push a fix to GIT with my next commits, next weekend
Current Projects: AI Traffic, Models & Liveries
User avatar
BecOzIcan
 
Posts: 1233
Joined: Tue Oct 04, 2011 10:43 pm
Location: Sydney, NSW, Australia
Version: 2.12
OS: Win10

Re: What traffic files are you doing

Postby wkitty42 » Wed Jul 08, 2020 4:31 pm

sounds like a plan ;)
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby wkitty42 » Thu Jul 09, 2020 6:24 pm

i found another one...

Code: Select all
~/flightgear-dev/fgdata-ng/AI/Traffic/L/LBT.xml:1862:      <port>EDDSP</port>


i think that's supposed to be EDDS or EDDP but i cannot tell because both are used nearby in the file...

this is another of marcin's traffic files...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby SP-KOK » Sat Jul 11, 2020 12:09 pm

It should be EDDP


I am sorry for my mistake
SP-KOK
 
Posts: 672
Joined: Tue Feb 02, 2016 5:04 pm

Re: What traffic files are you doing

Postby BecOzIcan » Sat Jul 11, 2020 12:17 pm

SAS radius correction already merged.
LBT departing ICAO correction commited. Will be merged next week
Current Projects: AI Traffic, Models & Liveries
User avatar
BecOzIcan
 
Posts: 1233
Joined: Tue Oct 04, 2011 10:43 pm
Location: Sydney, NSW, Australia
Version: 2.12
OS: Win10

Re: What traffic files are you doing

Postby wkitty42 » Sun Jul 12, 2020 3:23 pm

sounds good!

i came across a couple of other things, too... i've been (finally) able to start digging back into the AI code... i was having a weird problem that some of the values in some of my xml were not being used... finally tracked that down to the wrong tag being used in my files...

1. climbspeed-kts in the performancedb should be climb-speed-kts
2. cruisealt in flight plans should be cruise-alt

i've verified #1 exists in FGData and is not something i did to myself...
#2 might have been done by me but IIRC, i was using a spreadsheet to generate flight plans... i just don't recall where i got that sheet from and it has been a ""while"" since i used it or updated it...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby BecOzIcan » Sun Jul 12, 2020 3:31 pm

wkitty42 wrote in Sun Jul 12, 2020 3:23 pm:climbspeed-kts in the performancedb should be climb-speed-kts


Thanks. Please post in Devel for confirmation. 100% of the climbspeeds in the performanc.db are in this format. No documentation in wiki and verified FG 2.12 (2013) was already the same.

Cheers
Ian
Current Projects: AI Traffic, Models & Liveries
User avatar
BecOzIcan
 
Posts: 1233
Joined: Tue Oct 04, 2011 10:43 pm
Location: Sydney, NSW, Australia
Version: 2.12
OS: Win10

Re: What traffic files are you doing

Postby wkitty42 » Sun Jul 12, 2020 4:10 pm

BecOzIcan wrote in Sun Jul 12, 2020 3:31 pm:
wkitty42 wrote in Sun Jul 12, 2020 3:23 pm:climbspeed-kts in the performancedb should be climb-speed-kts


Thanks. Please post in Devel for confirmation.

not sure what you mean by this...

BecOzIcan wrote in Sun Jul 12, 2020 3:31 pm:100% of the climbspeeds in the performanc.db are in this format. No documentation in wiki and verified FG 2.12 (2013) was already the same.


yes, i'm very aware... i figured out the problem when i was adding some additional logging to understand the problem... the code plainly states, once one understands it, what the xml tags are that it is looking for ;)

here is the code that loads the data from the performancedb file... i've added the two SG_LOG lines to print the values to the log...
Code: Select all
void PerformanceData::initFromProps(SGPropertyNode *db_node)
{
// read the values, using the existing values as defaults
  _acceleration = db_node->getDoubleValue("acceleration-kts-hour", _acceleration);
  _deceleration = db_node->getDoubleValue("deceleration-kts-hour", _deceleration);
  _climbRate    = db_node->getDoubleValue("climbrate-fpm", _climbRate);
  _descentRate  = db_node->getDoubleValue("decentrate-fpm", _descentRate);
  _vRotate      = db_node->getDoubleValue("rotate-speed-kts", _vRotate);
  _vTakeOff     = db_node->getDoubleValue("takeoff-speed-kts", _vTakeOff);
  _vClimb       = db_node->getDoubleValue("climb-speed-kts", _vClimb);
  _vCruise      = db_node->getDoubleValue("cruise-speed-kts", _vCruise);
  _vDescent     = db_node->getDoubleValue("decent-speed-kts", _vDescent);
  _vApproach    = db_node->getDoubleValue("approach-speed-kts", _vApproach);
  _vTouchdown   = db_node->getDoubleValue("touchdown-speed-kts", _vTouchdown);
  _vTaxi        = db_node->getDoubleValue("taxi-speed-kts", _vTaxi);
  _wingSpan     = db_node->getDoubleValue("geometry/wing/span-ft", _wingSpan);
  _wingChord    = db_node->getDoubleValue("geometry/wing/chord-ft", _wingChord);
  _weight       = db_node->getDoubleValue("geometry/weight-lbs", _weight);
  SG_LOG(SG_AI, SG_DEBUG, "PerformanceData::initFromProps; " <<
                          "_acceleration "   << _acceleration <<
                          ", _deceleration " << _deceleration <<
                          ", _climbRate "    << _climbRate <<
                          ", _descentRate "  << _descentRate <<
                          ", _vRotate "      << _vRotate <<
                          ", _vTakeOff "     << _vTakeOff <<
                          ", _vClimb "       << _vClimb <<
                          ", _vCruise "      << _vCruise
        );
  SG_LOG(SG_AI, SG_DEBUG, "                                " <<
                          "_vDescent "     << _vDescent <<
                          ", _vApproach "    << _vApproach <<
                          ", _vTouchdown "   << _vTouchdown <<
                          ", _vTaxi "        << _vTaxi <<
                          ", _wingSpan "     << _wingSpan <<
                          ", _wingChord "    << _wingChord <<
                          ", _weight "       << _weight
        );
}


note: don't confuse climbrate-fpm with climb-speed-kts... the latter is what this is about... the former should be changed in the code, as well, so as to match the rest of the format but meh for now...

some things (eg: wingspan, wingchord, and craft weight) come from somewhere else and i don't know that they are used in the AI calculations but i'll be finding out one day as i continue to add more and more logging of all these numbers as i track their use through the AI Traffic code paths...

i've already found where several numbers are forced that should be taken from the perf db and used instead but i'm still working at understanding it all... eg: sending all craft to 10000 feet AGL alt when the flightplan clearly states the cruise alt is only 5000 feet AGL... similar with forcing 18000 and 15000 in the decent profile...

then there are other similar numbers used that are also not so good... especially one section that attempts to determine which leg of a flight is current based on the time of the flight... that certainly won't work for a GA craft with a cruise speed of 100kts compared to a commercial jet with a cruise speed of (eg) 350kts...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby BecOzIcan » Sun Jul 12, 2020 4:39 pm

wkitty42 wrote in Sun Jul 12, 2020 4:10 pm:not sure what you mean by this...

BecOzIcan wrote in Sun Jul 12, 2020 3:31 pm:100% of the climbspeeds in the performanc.db are in this format. No documentation in wiki and verified FG 2.12 (2013) was already the same.


I meant report bugs in the flightgear-devel mailing list so it can be looked at by the development team

Cheers
Ian
Current Projects: AI Traffic, Models & Liveries
User avatar
BecOzIcan
 
Posts: 1233
Joined: Tue Oct 04, 2011 10:43 pm
Location: Sydney, NSW, Australia
Version: 2.12
OS: Win10

Re: What traffic files are you doing

Postby wkitty42 » Sun Jul 12, 2020 7:54 pm

there is no code bug... it is a data bug... i thought we (TINW) were also keeping the performancedb updated with our AI plane data when we work with one that is either wrong or not in the file??

i remember talking about the misspelled "decent" tag name back when we were talking about and sharing perf data here ;)
but this is about fixing the tags in the perf database file...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby BecOzIcan » Sun Jul 12, 2020 11:29 pm

The Tag itself AFAIK is part of the data model ie structural. Given the potential impact of such a change on 100% of FG users I am no touching it until the central team has confirmed the tag is wrong and not the one expected by downstream systems..
Current Projects: AI Traffic, Models & Liveries
User avatar
BecOzIcan
 
Posts: 1233
Joined: Tue Oct 04, 2011 10:43 pm
Location: Sydney, NSW, Australia
Version: 2.12
OS: Win10

Re: What traffic files are you doing

Postby wkitty42 » Mon Jul 13, 2020 12:03 am

really? the code has been looking for tag X since it was written and added to the repo... no one has touched it since then... all of the perf database stuff that has been using the wrong tag for yonks needs to be changed... it is not a question of which came first...

1. the code is always right.
2. if the code doesn't match what the documentation says, change the documentation.

this is the standard way of things...

but look, you have a path way into the AI stuff in FGData... you (now) know that those tags are wrong... why not fix them to match the code and submit them the same way you do all of your submissions of AI flight plans?? i mean, a simple search and replace will take care of it but if you rather a patch file, one can easily be generated and sent... and since you already have the AI Traffic pathway into FGData, why not use it?? serious question with no "ugly" hidden underneath...
"You get more air close to the ground," said Angalo. "I read that in a book. You get lots of air low down, and not much when you go up."
"Why not?" said Gurder.
"Dunno. It's frightened of heights, I guess."
User avatar
wkitty42
 
Posts: 6816
Joined: Fri Feb 20, 2015 3:46 pm
Location: central NC, USA
Callsign: wk42
Version: git next
OS: Kubuntu 20.04

Re: What traffic files are you doing

Postby BecOzIcan » Mon Jul 13, 2020 11:27 pm

Issue now reviewed and confirmed by James. I will update the file and run testing before inclusion in the next release.

Cheers
Ian
Current Projects: AI Traffic, Models & Liveries
User avatar
BecOzIcan
 
Posts: 1233
Joined: Tue Oct 04, 2011 10:43 pm
Location: Sydney, NSW, Australia
Version: 2.12
OS: Win10

PreviousNext

Return to AI Traffic

Who is online

Users browsing this forum: No registered users and 1 guest